WangJPLeo commented on code in PR #9955:
URL: https://github.com/apache/dolphinscheduler/pull/9955#discussion_r873347436
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/consumer/TaskPriorityQueueConsumer.java:
##########
@@ -120,12 +140,13 @@ public void run() {
if (!failedDispatchTasks.isEmpty()) {
for (TaskPriority dispatchFailedTask :
failedDispatchTasks) {
- taskPriorityQueue.put(dispatchFailedTask);
- }
- // If there are tasks in a cycle that cannot find the
worker group,
- // sleep for 1 second
- if (taskPriorityQueue.size() <=
failedDispatchTasks.size()) {
-
TimeUnit.MILLISECONDS.sleep(Constants.SLEEP_TIME_MILLIS);
+ if (dispatchFailedTask.getDispatchFailedRetryTimes()
>= Constants.DEFAULT_MAX_RETRY_COUNT){
+ logger.error("the number of retries for dispatch
failure has exceeded the maximum limit, taskId: {} processInstanceId: {}",
dispatchFailedTask.getTaskId(), dispatchFailedTask.getProcessInstanceId());
+ // business alarm
+ continue;
Review Comment:
Yes, Thanks. After retries 100 times, the business alarm, and then continue
to retry according to each 100s delay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
