[GitHub] [dolphinscheduler] 106umao commented on a diff in pull request #10265: [Feature][Resource] Add local resource system support in configuration resource.storage.type=HDFS_LOCAL #9385

Fri, 27 May 2022 03:53:32 -0700 


106umao commented on code in PR #10265:
URL: https://github.com/apache/dolphinscheduler/pull/10265#discussion_r883502164


##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/config/StoreConfiguration.java:
##########
@@ -43,6 +46,12 @@ public StorageOperate storageOperate() {
         switch (PropertyUtils.getString(RESOURCE_STORAGE_TYPE)) {
             case STORAGE_S3:
                 return S3Utils.getInstance();
+            case STORAGE_LOCAL:
+                // override the FS_DEFAULT_FS configuration
+                PropertyUtils.setValue(FS_DEFAULT_FS,STORAGE_LOCAL_DEFAULT_FS);

Review Comment:
   > String defaultFS = configuration.get(Constants.FS_DEFAULT_FS);
   
   `String defaultFS = configuration.get(Constants.FS_DEFAULT_FS); `
   the `defaultFS` is always "file:///" , so ` defaultFS.startsWith("file")` is 
always true ，and `defaultFSProp `is the value configured in the configuration 
file, which is the value I passed in 
   
![image](https://user-images.githubusercontent.com/50058173/170685278-0debe19e-0586-4f54-856d-5547b9198ec1.png)
   I output these two values on the code, let's take a look：
   
![image](https://user-images.githubusercontent.com/50058173/170685541-a940c7f1-c7b7-430a-85b9-92f00e0bdc3a.png)
   
![image](https://user-images.githubusercontent.com/50058173/170685860-1e995e32-a1dd-4e39-8445-a91992ea6eb8.png)
   The logic of my pr can be seen as the following pseudo code:
   `if (resource.storage.type==HDFS_LOCAL) fs.defaultFS=file:///`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to