zhongjiajie commented on code in PR #10265:
URL: https://github.com/apache/dolphinscheduler/pull/10265#discussion_r885168893
##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/config/StoreConfiguration.java:
##########
@@ -43,6 +44,7 @@ public StorageOperate storageOperate() {
switch (PropertyUtils.getString(RESOURCE_STORAGE_TYPE)) {
case STORAGE_S3:
return S3Utils.getInstance();
+ case STORAGE_LOCAL:
Review Comment:
Does we missing this statement?
```suggestion
case STORAGE_LOCAL:
return HadoopUtils.getInstance();
```
##########
docs/docs/en/guide/resource/configuration.md:
##########
@@ -11,7 +11,7 @@ For a single machine, you can choose to use local file
directory as the upload d
Configure the file in the following paths: `api-server/conf/common.properties`
and `worker-server/conf/common.properties`.
- Change `data.basedir.path` to the local directory path. Please make sure the
user who deploy dolphinscheduler have read and write permissions, such as:
`data.basedir.path=/tmp/dolphinscheduler`. And the directory you configured
will be auto-created if it does not exists.
-- Modify the following two parameters, `resource.storage.type=HDFS` and
`fs.defaultFS=file:///`.
+- Modify the following two parameters, `resource.storage.type=HDFS` and
`fs.defaultFS=file:///` or modify `resource.storage.type=LOCAL` alone, it will
use HDFS local mode and will automatically configure `fs.defaultFS=file:///`.
Review Comment:
Please also change the ZH doc
##########
docs/docs/en/guide/resource/configuration.md:
##########
@@ -11,7 +11,7 @@ For a single machine, you can choose to use local file
directory as the upload d
Configure the file in the following paths: `api-server/conf/common.properties`
and `worker-server/conf/common.properties`.
- Change `data.basedir.path` to the local directory path. Please make sure the
user who deploy dolphinscheduler have read and write permissions, such as:
`data.basedir.path=/tmp/dolphinscheduler`. And the directory you configured
will be auto-created if it does not exists.
-- Modify the following two parameters, `resource.storage.type=HDFS` and
`fs.defaultFS=file:///`.
+- Modify the following two parameters, `resource.storage.type=HDFS` and
`fs.defaultFS=file:///` or modify `resource.storage.type=LOCAL` alone, it will
use HDFS local mode and will automatically configure `fs.defaultFS=file:///`.
Review Comment:
We should suggest users using the `LOCAL` directly, and manually change can
be backup
```suggestion
- modify `resource.storage.type=LOCAL` which will use HDFS local mode and
will automatically configure `fs.defaultFS=file:///`. And you can also modify
the following two parameters, `resource.storage.type=HDFS` and
`fs.defaultFS=file:///` manually.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
