[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #10303: [Bug][Api-Server]Fix bug when user without tenant uploads file in resource center

Mon, 30 May 2022 19:36:31 -0700 


EricGao888 commented on code in PR #10303:
URL: https://github.com/apache/dolphinscheduler/pull/10303#discussion_r885157782


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ResourcesServiceImpl.java:
##########
@@ -651,7 +666,14 @@ private boolean upload(User loginUser, String fullName, 
MultipartFile file, Reso
             return false;
         }
         // query tenant
-        String tenantCode = 
tenantMapper.queryById(loginUser.getTenantId()).getTenantCode();
+        Tenant tenant = tenantMapper.queryById(loginUser.getTenantId());
+        // this could happen when user logs in as admin
+        if (tenant == null) {
+            logger.error("fail to acquire tenant, please set tenant for login 
user/admin first");

Review Comment:
   Looks like `CURRENT_LOGIN_USER_TENANT_NOT_EXIST` already has instructive 
message here. Do you have any suggestions on how to put `logger.error` to WEB 
UI? We also need to think about i18n issue. 
   
![image](https://user-images.githubusercontent.com/34905992/171081106-cbd6f2c6-26e4-4013-bca8-9976574ac1e3.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to