zhongjiajie commented on code in PR #10303:
URL: https://github.com/apache/dolphinscheduler/pull/10303#discussion_r885164105
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ResourcesServiceImpl.java:
##########
@@ -651,7 +666,14 @@ private boolean upload(User loginUser, String fullName,
MultipartFile file, Reso
return false;
}
// query tenant
- String tenantCode =
tenantMapper.queryById(loginUser.getTenantId()).getTenantCode();
+ Tenant tenant = tenantMapper.queryById(loginUser.getTenantId());
+ // this could happen when user logs in as admin
+ if (tenant == null) {
+ logger.error("fail to acquire tenant, please set tenant for login
user/admin first");
Review Comment:
Are we still need this? in this patch we already have function verifyTenant
in and function upload only working on createResource and updateResource. If we
add verifyTenant to both of them, do we still need this check in upload?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
