EricGao888 commented on code in PR #10451:
URL: https://github.com/apache/dolphinscheduler/pull/10451#discussion_r897607181


##########
docs/docs/en/architecture/configuration.md:
##########
@@ -226,6 +226,7 @@ 
security.authentication.ldap.username|cn=read-only-admin,dc=example,dc=com|LDAP
 security.authentication.ldap.password|password|LDAP password
 security.authentication.ldap.user.identity.attribute|uid|LDAP user identity 
attribute 
 security.authentication.ldap.user.email.attribute|mail|LDAP user email 
attribute
+security.authentication.ldap.user.not.exist.action|CREATION|action when LDAP 
user is not exist

Review Comment:
   What about using `CREATE` instead of `CREATION` to maintain consistency with 
`DENY`? Since `DENY` is used instead of `DENIAL`. BTW, will it be better to add 
a line to explain the `DENY` option in docs?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to