kezhenxu94 commented on code in PR #10451:
URL: https://github.com/apache/dolphinscheduler/pull/10451#discussion_r897630215
##########
dolphinscheduler-api/src/main/resources/application.yaml:
##########
@@ -143,6 +143,8 @@ security:
password: password
user.identity.attribute: uid
user.email.attribute: mail
+ # action when ldap user is not exist (supported types: CREATE,DENY)
+ user.not.exist.action: CREATE
Review Comment:
1. Please use YAML hierarchy to re-organize the configs (including
`user.email.attribute`, `user.identity.attribute`, `user.admin`), and you
should rename the config a little bit (not using `.` to split as in YAML that
will become a new section), an example below
```suggestion
user:
admin: ""
email-attribute: ""
identity-attribute: ""
absent-policy: CREATE
```
2. When adding a new config, make sure its default value is the same as the
one before you add this config. Previously the policy is `DENY` so you should
set the default value of the new config as `DENY`, so that users don't face
different behaviors after upgrading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
