guodongym commented on code in PR #10433: URL: https://github.com/apache/dolphinscheduler/pull/10433#discussion_r898148715
########## docs/docs/zh/architecture/configuration.md: ########## @@ -178,18 +178,20 @@ common.properties配置文件目前主要是配置hadoop/s3a相关的配置. |--|--|--| data.basedir.path|/tmp/dolphinscheduler|本地工作目录,用于存放临时文件 resource.storage.type|NONE|资源文件存储类型: HDFS,S3,NONE -resource.upload.path|/dolphinscheduler|资源文件存储路径 +resource.storage.upload.base.path|/dolphinscheduler|资源文件存储路径 +resource.aws.access.key.id| minioadmin| S3 access key +resource.aws.secret.access.key| minioadmin| S3 secret access key +resource.aws.region|us-east-1| S3 区域 +resource.aws.s3.bucket.name| dolphinscheduler-test| S3 存储桶名称 +resource.aws.s3.endpoint| http://minio:9000| s3 endpoint地址 +resource.hdfs.root.user|hdfs|如果存储类型为HDFS,需要配置拥有对应操作权限的用户 +resource.hdfs.fs.defaultFS|hdfs://mycluster:8020|请求地址如果resource.storage.type=S3,该值类似为: s3a://dolphinscheduler. 如果resource.storage.type=HDFS, 如果 hadoop 配置了 HA,需要复制core-site.xml 和 hdfs-site.xml 文件到conf目录 Review Comment: The modified ########## dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/S3Utils.java: ########## @@ -221,33 +236,21 @@ public boolean upload(String tenantCode, String srcFile, String dstPath, boolean s3Client.putObject(BUCKET_NAME, dstPath, new File(srcFile)); return true; } catch (AmazonServiceException e) { - logger.error("upload failed,the bucketName is {},the dstPath is {}", BUCKET_NAME, tenantCode+ FOLDER_SEPARATOR +dstPath); + logger.error("upload failed,the bucketName is {},the dstPath is {}", BUCKET_NAME, tenantCode + FOLDER_SEPARATOR + dstPath); Review Comment: The modified -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
