SbloodyS commented on code in PR #10433:
URL: https://github.com/apache/dolphinscheduler/pull/10433#discussion_r898615563
##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/S3Utils.java:
##########
@@ -293,15 +339,28 @@ private void downloadDirectory(String tenantCode, String
keyPrefix, String srcP
}
}
- public void checkBucketNameIfNotPresent(String bucketName) {
- if (!s3Client.doesBucketExistV2(bucketName)) {
- logger.info("the current regionName is {}",
s3Client.getRegionName());
- s3Client.createBucket(bucketName);
+ public void checkBucketNameExists(String bucketName) {
+ if (StringUtils.isBlank(bucketName)) {
+ Stopper.stop();
Review Comment:
I think stop retry thread is not a good idea. If the user create the bucket
during the retry. It should succeed instead of stop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
