guoshupei commented on code in PR #10563:
URL: https://github.com/apache/dolphinscheduler/pull/10563#discussion_r907403061
##########
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/registry/RegistryClient.java:
##########
@@ -97,7 +98,7 @@ public List<Server> getServerList(NodeType nodeType) {
List<Server> serverList = new ArrayList<>();
for (Map.Entry<String, String> entry : serverMaps.entrySet()) {
- HeartBeat heartBeat = HeartBeat.decodeHeartBeat(entry.getValue());
+ HeartBeatModel heartBeat =
HeartBeatUtils.decodeHeartBeat(entry.getValue(), nodeType);
Review Comment:
First , thank you very much for your patient explanation And I really agree
with you. If `HeartBeatModel ` is deleted, there may be some hard coding in
the master, which I cannot accept at present. Therefore, I am ready to give up
this PR. I hope that if someone changes it, you can tell me. I want to learn it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
