[GitHub] [dolphinscheduler] guoshupei commented on a diff in pull request #10563: [improve-10506] [server] add MasterHeartBeat and WorkerHeartBeat to extend HeartBeat

Tue, 28 Jun 2022 07:23:39 -0700 


guoshupei commented on code in PR #10563:
URL: https://github.com/apache/dolphinscheduler/pull/10563#discussion_r908547833


##########
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/registry/RegistryClient.java:
##########
@@ -97,7 +98,7 @@ public List<Server> getServerList(NodeType nodeType) {
 
         List<Server> serverList = new ArrayList<>();
         for (Map.Entry<String, String> entry : serverMaps.entrySet()) {
-            HeartBeat heartBeat = HeartBeat.decodeHeartBeat(entry.getValue());
+            HeartBeatModel heartBeat = 
HeartBeatUtils.decodeHeartBeat(entry.getValue(), nodeType);

Review Comment:
   First, we need to reach a consensus that `WorkerHeartBeat` must autowared 
`WorkerManagerThread` in order to get `WorkerWaitingTaskCount`.
   
   As you said，`WorkerHeartBeat` in `common` module, but `worker` module 
depend` common` module and `WorkerManagerThread` in `worker` module.
   
![image](https://user-images.githubusercontent.com/29919212/176203192-8b57a207-1a94-4f05-b94b-0724f7914b71.png)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to