guoshupei commented on code in PR #10563:
URL: https://github.com/apache/dolphinscheduler/pull/10563#discussion_r909233172
##########
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/registry/RegistryClient.java:
##########
@@ -97,7 +98,7 @@ public List<Server> getServerList(NodeType nodeType) {
List<Server> serverList = new ArrayList<>();
for (Map.Entry<String, String> entry : serverMaps.entrySet()) {
- HeartBeat heartBeat = HeartBeat.decodeHeartBeat(entry.getValue());
+ HeartBeatModel heartBeat =
HeartBeatUtils.decodeHeartBeat(entry.getValue(), nodeType);
Review Comment:
I have some questions to confirm.
- 1. Do we need to define a `WorkerHeartbeatTask` ?
- 2. What do you mean `WorkerHeartbeatTask` autowared `WorkerManagerThread`
?
- 3. Which module is `WorkerHeartbeatTask` in ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
