ruanwenjun commented on code in PR #10718:
URL: https://github.com/apache/dolphinscheduler/pull/10718#discussion_r913464803
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/WorkerGroupServiceImpl.java:
##########
@@ -84,6 +84,7 @@ public class WorkerGroupServiceImpl extends BaseServiceImpl
implements WorkerGro
* @return create or update result code
*/
@Override
+ @Transactional(rollbackFor = Exception.class)
Review Comment:
Please don't set the rollbackFor, if you set this then this method will only
rollback a checked Exception, but you can know this method will not throw a
checked Exception, if you want to rollback in all case, you can set rollbackFor
= Throwable.class, but in this case ,you need to use rollbackFor =
RuntimeException.class
```suggestion
@Transactional
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
