WangJPLeo commented on code in PR #10718:
URL: https://github.com/apache/dolphinscheduler/pull/10718#discussion_r913479278
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/WorkerGroupServiceImpl.java:
##########
@@ -84,6 +84,7 @@ public class WorkerGroupServiceImpl extends BaseServiceImpl
implements WorkerGro
* @return create or update result code
*/
@Override
+ @Transactional(rollbackFor = Exception.class)
Review Comment:
yeah, thx for this, 'If no rules are relevant to the exception, it will be
treated like DefaultTransactionAttribute (rolling back on runtime exceptions)',
without adding properties such as rollbackFor, Spring will roll back when
Unchecked Exceptions are encountered, not only RuntimeException, but also
Error. I will optimize it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
