kezhenxu94 commented on code in PR #10749:
URL: https://github.com/apache/dolphinscheduler/pull/10749#discussion_r914434736
##########
dolphinscheduler-meter/src/main/resources/grafana/DolphinSchedulerWorker.json:
##########
@@ -172,7 +172,7 @@
"showThresholdLabels": false,
"showThresholdMarkers": false
},
- "pluginVersion": "8.5.3",
+ "pluginVersion": "9.0.0-beta2",
Review Comment:
I don't recommend using a beta version of plugin
##########
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/metrics/WorkerServerMetrics.java:
##########
@@ -37,6 +36,36 @@ public class WorkerServerMetrics {
.description("full worker submit queues count")
.register(Metrics.globalRegistry);
+ private static final Counter WORKER_RESOURCE_DOWNLOAD_COUNTER =
+ Counter.builder("ds.worker.resource.download.count")
+ .description("worker resource download count")
+ .register(Metrics.globalRegistry);
+
+ private static final Counter WORKER_RESOURCE_DOWNLOAD_SUCCESS_COUNTER =
+ Counter.builder("ds.worker.resource.download.success.count")
+ .description("worker resource download success count")
+ .register(Metrics.globalRegistry);
+
+ private static final Counter WORKER_RESOURCE_DOWNLOAD_FAILURE_COUNTER =
+ Counter.builder("ds.worker.resource.download.failure.count")
+ .description("worker resource download failure count")
+ .register(Metrics.globalRegistry);
+
+ private static final Timer WORKER_RESOURCE_DOWNLOAD_DURATION_TIMER =
+ Timer.builder("ds.worker.resource.download.duration")
+ .publishPercentiles(0.5, 0.75, 0.95, 0.99)
+ .publishPercentileHistogram()
+ .description("time cost of resource download on workers")
+ .register(Metrics.globalRegistry);
+
Review Comment:
Hi, I didn't notice this, but for `counter`, `successful counter` and
`failure counter`, we usually use only one `counter` and add
`status=success`/`status=failure` tags so we don't have 3 counters for only one
metrics
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
