EricGao888 commented on code in PR #10749:
URL: https://github.com/apache/dolphinscheduler/pull/10749#discussion_r914436941
##########
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/metrics/WorkerServerMetrics.java:
##########
@@ -37,6 +36,36 @@ public class WorkerServerMetrics {
.description("full worker submit queues count")
.register(Metrics.globalRegistry);
+ private static final Counter WORKER_RESOURCE_DOWNLOAD_COUNTER =
+ Counter.builder("ds.worker.resource.download.count")
+ .description("worker resource download count")
+ .register(Metrics.globalRegistry);
+
+ private static final Counter WORKER_RESOURCE_DOWNLOAD_SUCCESS_COUNTER =
+ Counter.builder("ds.worker.resource.download.success.count")
+ .description("worker resource download success count")
+ .register(Metrics.globalRegistry);
+
+ private static final Counter WORKER_RESOURCE_DOWNLOAD_FAILURE_COUNTER =
+ Counter.builder("ds.worker.resource.download.failure.count")
+ .description("worker resource download failure count")
+ .register(Metrics.globalRegistry);
+
+ private static final Timer WORKER_RESOURCE_DOWNLOAD_DURATION_TIMER =
+ Timer.builder("ds.worker.resource.download.duration")
+ .publishPercentiles(0.5, 0.75, 0.95, 0.99)
+ .publishPercentileHistogram()
+ .description("time cost of resource download on workers")
+ .register(Metrics.globalRegistry);
+
Review Comment:
Sure, thx for pointing this out. I will fix it and the related issues in the
commits before in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
