caishunfeng commented on code in PR #10910:
URL: https://github.com/apache/dolphinscheduler/pull/10910#discussion_r919567437
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java:
##########
@@ -1813,7 +1814,7 @@ protected List<TaskInstance>
getRecoverTaskInstanceList(String cmdParam) {
if (paramMap != null &&
paramMap.containsKey(CMD_PARAM_RECOVERY_START_NODE_STRING)) {
String[] idList =
paramMap.get(CMD_PARAM_RECOVERY_START_NODE_STRING).split(Constants.COMMA);
if (ArrayUtils.isNotEmpty(idList)) {
- List<Integer> taskInstanceIds =
Arrays.stream(idList).map(Integer::valueOf).collect(Collectors.toList());
+ List<Integer> taskInstanceIds =
Arrays.stream(idList).filter(StringUtils::isNotEmpty).map(Integer::valueOf).collect(Collectors.toList());
Review Comment:
It's better to check empty id when setting, so we don't have to filter it
anywhere we use.
##########
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/AccessTokenMapper.java:
##########
@@ -36,14 +36,14 @@ public interface AccessTokenMapper extends
BaseMapper<AccessToken> {
/**
* access token page
*
+ * @param ids
* @param page page
* @param userName userName
- * @param userId userId
* @return access token Ipage
*/
IPage<AccessToken> selectAccessTokenPage(Page page,
- @Param("userName") String
userName,
- @Param("userId") int userId
+ @Param("ids") List<Integer> ids,
Review Comment:
```suggestion
@Param("ids") List<Integer>
tokenIds,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
