SbloodyS commented on code in PR #10910: URL: https://github.com/apache/dolphinscheduler/pull/10910#discussion_r919620342
########## dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-http/src/main/java/org/apache/dolphinscheduler/plugin/alert/http/HttpSender.java: ########## @@ -40,6 +38,11 @@ import java.util.HashMap; import java.util.Map; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import com.fasterxml.jackson.databind.node.ObjectNode; + Review Comment: > I am not sure whether we should do that or not, I think @SbloodyS @kezhenxu94 have discussed about this, we should change the code style unless we change the specific file Yes. Modifying irrelevant files may lead to many conflicts in other pr. It's better only modify related files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
