rickchengx commented on PR #11508: URL: https://github.com/apache/dolphinscheduler/pull/11508#issuecomment-1221711238
> 11402 not only allows users to modify the configs before starting DS components, but also allows users to modify the configs without restarting the components and the configs can be reloaded at runtime. @kezhenxu94 Sorry for the late response. I understand that 11402 could allow users to modify the configs without restarting the components and the configs can be reloaded at runtime. But my point is that if users use `Helm` to deploy DS in a k8s cluster and he wants to modify some configs (E.g., the `root directory` of zookeeper in `application.yaml`) **before deploying the DS**. In this case, DS cannot apply some configuration modifications at startup unless he modifies the configuration file in the docker image (**Some configurations cannot be specified via** `values.yaml`). E.g., he modifies the `application.yaml` and **rebuilds the docker image** with `ADD application.yaml to /opt/dolphinscheduler/conf` in `Dockerfile`. This PR mainly mounts the configuration directory through `configmap` so that users can **avoid rebuilding the docker image** if he wants to modify the configs before deploying DS to k8s through `Helm`. As for 11402, users can still modify the configs without restarting the components and the configs can be reloaded at runtime. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
