kezhenxu94 commented on PR #11508:
URL: 
https://github.com/apache/dolphinscheduler/pull/11508#issuecomment-1236505138

   > > @rickchengx now, in the master, if the user wants to modify some 
configurations, they can just `kubectl create configmap master-server 
--from-file=/path/to/the/master/application.yaml` or `kubectl create configmap 
worker-server --from-file=/path/to/the/worker/application.yaml`, etc.. Does 
this solve your problem?
   > > ALso, the benefit of 👆 compared to your changes, is that, users can just 
provide a patch config without copying the whole `application.yaml`, this is 
convenient when upgrading to a newer version so users don't need to compare the 
2 config files and cherrypick the new config section.
   > 
   > @kezhenxu94 you only created these configmaps, but not mounting them into 
deployment/statefulset, which will not be seen by DS pods, right?
   
   Please learn how Spring Cloud works, DS components will automatically pick 
up the config map, please also read 
https://github.com/apache/dolphinscheduler/pull/11730#issue-1358375669


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to