insist777 commented on code in PR #11670:
URL: https://github.com/apache/dolphinscheduler/pull/11670#discussion_r970258725
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/task/CommonTaskProcessor.java:
##########
@@ -171,4 +177,25 @@ private void killRemoteTask() throws ExecuteException {
nettyExecutorManager.executeDirectly(executionContext);
}
+
+ protected void checkAndReplaceTestDataSource() {
Review Comment:
In my first version, I replaced it when creating TaskInstance. Since only
tasks of common type are sent to the worker, including tasks with bound data
sources, such as SQL, and tasks without bound data sources, such as shell, the
data source is replaced here, and the control task type has been fine-grained.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
