insist777 commented on code in PR #11670:
URL: https://github.com/apache/dolphinscheduler/pull/11670#discussion_r974920751
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/DataSourceController.java:
##########
@@ -148,23 +148,25 @@ public Result queryDataSource(@ApiIgnore
@RequestAttribute(value = Constants.SES
}
/**
- * query datasource by type
+ * query online/testDatasource by type
*
* @param loginUser login user
* @param type data source type
* @return data source list page
*/
@ApiOperation(value = "queryDataSourceList", notes =
"QUERY_DATA_SOURCE_LIST_BY_TYPE_NOTES")
@ApiImplicitParams({
- @ApiImplicitParam(name = "type", value = "DB_TYPE", required =
true, dataType = "DbType")
+ @ApiImplicitParam(name = "type", value = "DB_TYPE", required =
true, dataType = "DbType"),
+ @ApiImplicitParam(name = "testFlag", value = "DB_TEST_FLAG",
required = true, dataType = "DbTestFlag")
})
@GetMapping(value = "/list")
@ResponseStatus(HttpStatus.OK)
@ApiException(QUERY_DATASOURCE_ERROR)
@AccessLogAnnotation(ignoreRequestArgs = "loginUser")
public Result queryDataSourceList(@ApiIgnore @RequestAttribute(value =
Constants.SESSION_USER) User loginUser,
- @RequestParam("type") DbType type) {
- Map<String, Object> result =
dataSourceService.queryDataSourceList(loginUser, type.ordinal());
+ @RequestParam("type") DbType type,
Review Comment:
https://github.com/apache/dolphinscheduler/pull/12062
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
