ruanwenjun commented on code in PR #12051:
URL: https://github.com/apache/dolphinscheduler/pull/12051#discussion_r974821956
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/task/CommonTaskProcessor.java:
##########
@@ -126,6 +133,14 @@ public boolean dispatchTask() {
return false;
}
+ // check in advance to avoid invalid infinite loops in
TaskPriorityQueueConsumer
+ if
(CollectionUtils.isEmpty(serverNodeManager.getWorkerGroupNodes(taskExecutionContext.getWorkerGroup())))
{
Review Comment:
We cannot make this change easily, the workgroup may loss in some cases, and
recovery automically.
And this is not safe, the workflow may exist in the processor but loss in
dispatch part.
BTY, it's not suggested to do this validation master, we need to do the
validation in api-side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
