DarkAssassinator commented on code in PR #12051:
URL: https://github.com/apache/dolphinscheduler/pull/12051#discussion_r977829796
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/task/CommonTaskProcessor.java:
##########
@@ -126,6 +133,14 @@ public boolean dispatchTask() {
return false;
}
+ // check in advance to avoid invalid infinite loops in
TaskPriorityQueueConsumer
+ if
(CollectionUtils.isEmpty(serverNodeManager.getWorkerGroupNodes(taskExecutionContext.getWorkerGroup())))
{
Review Comment:
> Add validation in API-Side can stop the process in workflow creation. In
fact, we have this check in front-end, but in api-side, we don't validate the
workgroup.
u are correct, i add a validator in api side and remove it in master side
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
