caishunfeng commented on code in PR #12059:
URL: https://github.com/apache/dolphinscheduler/pull/12059#discussion_r976160075
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-sql/src/main/java/org/apache/dolphinscheduler/plugin/task/sql/SqlTask.java:
##########
@@ -269,7 +270,10 @@ private String resultProcess(ResultSet resultSet) throws
Exception {
logger.info("row {} : {}", i + 1, row);
}
}
- String result = JSONUtils.toJsonString(resultJSONArray);
+
+ String result = resultJSONArray.isEmpty() ?
Review Comment:
Is it OK if return the empty row? Because it will deal out param if define
the param pass.
see
https://dolphinscheduler.apache.org/zh-cn/docs/dev/user_doc/guide/parameter/context.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
