[GitHub] [dolphinscheduler] fengjian1129 commented on a diff in pull request #12059: [Bug-#12057][task-plugin] fix when the sql query result is empty, the email fails to send the attachment, and an exception will be reported

[GitBox]

fengjian1129 commented on code in PR #12059:
URL: https://github.com/apache/dolphinscheduler/pull/12059#discussion_r976234472


##########
dolphinscheduler-task-plugin/dolphinscheduler-task-sql/src/main/java/org/apache/dolphinscheduler/plugin/task/sql/SqlTask.java:
##########
@@ -269,7 +270,10 @@ private String resultProcess(ResultSet resultSet) throws 
Exception {
                 logger.info("row {} : {}", i + 1, row);
             }
         }
-        String result = JSONUtils.toJsonString(resultJSONArray);
+
+        String result = resultJSONArray.isEmpty() ?

Review Comment:
   I tested it according to the document, such as
   <img width="536" alt="image" 
src="https://user-images.githubusercontent.com/35831367/191460410-f5c84b86-19fa-43cb-af22-3f9751839560.png";>
   <img width="333" alt="image" 
src="https://user-images.githubusercontent.com/35831367/191460778-847e19fb-410c-4f8f-be01-b3b31fcfff32.png";>
   
   I think it is in line with expectations
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org