EricPyZhou commented on code in PR #12076: URL: https://github.com/apache/dolphinscheduler/pull/12076#discussion_r979512839
########## dolphinscheduler-dao/src/main/resources/sql/dolphinscheduler_mysql.sql: ########## @@ -790,6 +790,22 @@ CREATE TABLE `t_ds_resources` ( -- Records of t_ds_resources -- ---------------------------- +-- ---------------------------- +-- Table structure for t_ds_relation_resources_task +-- ---------------------------- +DROP TABLE IF EXISTS `t_ds_relation_resources_task`; +CREATE TABLE `t_ds_relation_resources_task` ( + `id` int NOT NULL AUTO_INCREMENT COMMENT 'key', + `full_name` varchar(255) DEFAULT NULL, + `type` tinyint DEFAULT NULL COMMENT 'resource type,0:FILE,1:UDF', + PRIMARY KEY (`id`), + UNIQUE KEY `t_ds_relation_resources_task_un` (`full_name`,`type`) +) ENGINE=InnoDB AUTO_INCREMENT=1 DEFAULT CHARSET=utf8mb3 Review Comment: @caishunfeng @SbloodyS In the latest commit, I added the `task_id` field. While testing it, I found there was no logic in updating task definition-related tables in the repo. For example, In the current implementation, the modification to resources (rename, delete) used by a task won't update the task definition log, which it should. Therefore, at the end I used `processDefinitionService.updateProcessDefinition()` to implement the logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
