SbloodyS commented on code in PR #12076:
URL: https://github.com/apache/dolphinscheduler/pull/12076#discussion_r990737876
##########
dolphinscheduler-ui/src/views/resource/udf/resource/use-table.ts:
##########
@@ -265,15 +281,18 @@ export function useTable() {
variables.row = row
}
- const handleDelete = (id: number) => {
+ const handleDelete = (id: number, fullNameObj: {fullName: string,
tenantCode: string}) => {
/* after deleting data from the current page, you need to jump forward
when the page is empty. */
if (variables.tableData.length === 1 && variables.page > 1) {
variables.page -= 1
}
- deleteResource(id).then(() =>
+ deleteResource(id, fullNameObj).then(() =>
getTableData({
- id: variables.id,
+ id: -1,
+// id: variables.id,
Review Comment:
Same here.
##########
dolphinscheduler-ui/src/views/resource/file/table/use-table.ts:
##########
@@ -86,13 +85,13 @@ export function useTable(renameResource: IRenameFile,
updateList: () => void) {
{
title: t('resource.file.file_name'),
...COLUMN_WIDTH_CONFIG['name'],
- key: 'file_name'
- },
- {
- title: t('resource.file.description'),
- ...COLUMN_WIDTH_CONFIG['note'],
- key: 'description'
+ key: 'fullName'
},
+// {
+// title: t('resource.file.description'),
+// ...COLUMN_WIDTH_CONFIG['note'],
+// key: 'description'
+// },
Review Comment:
Same here.
##########
dolphinscheduler-ui/src/views/resource/udf/resource/use-table.ts:
##########
@@ -117,19 +120,19 @@ export function useTable() {
{
title: t('resource.udf.file_name'),
...COLUMN_WIDTH_CONFIG['name'],
- key: 'fileName'
+ key: 'fullName'
},
{
title: t('resource.udf.file_size'),
key: 'size',
...COLUMN_WIDTH_CONFIG['size'],
render: (row) => bytesToSize(row.size)
},
- {
- title: t('resource.udf.description'),
- key: 'description',
- ...COLUMN_WIDTH_CONFIG['note']
- },
+// {
+// title: t('resource.udf.description'),
+// key: 'description',
+// ...COLUMN_WIDTH_CONFIG['note']
+// },
Review Comment:
Please remove unnessnary comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
