EricGao888 commented on code in PR #12197:
URL: https://github.com/apache/dolphinscheduler/pull/12197#discussion_r983306935


##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/FileUtils.java:
##########
@@ -119,7 +126,7 @@ public static String getResourceViewSuffixes() {
      * @throws IOException errors
      */
     public static void createWorkDirIfAbsent(String execLocalPath) throws 
IOException {
-        //if work dir exists, first delete
+        // if work dir exists, first delete

Review Comment:
   I'd rather we just remove this line of comment. The code has indicated what 
it is doing here. BTW, this comment has already been away from the code, which 
also shows it is hard to maintain such kind of comment.
   
   ```java
    if (execLocalPathFile.exists()) {
               try {
                   
org.apache.commons.io.FileUtils.forceDelete(execLocalPathFile);
   ......
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to