fuchanghai commented on code in PR #12197:
URL: https://github.com/apache/dolphinscheduler/pull/12197#discussion_r983568190
##########
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/utils/TaskExecutionCheckerUtils.java:
##########
@@ -75,14 +75,14 @@ public static void checkTenantExist(WorkerConfig
workerConfig, TaskExecutionCont
public static void createProcessLocalPathIfAbsent(TaskExecutionContext
taskExecutionContext) throws TaskException {
try {
// local execute path
- String execLocalPath = FileUtils.getProcessExecDir(
- taskExecutionContext.getProjectCode(),
- taskExecutionContext.getProcessDefineCode(),
- taskExecutionContext.getProcessDefineVersion(),
- taskExecutionContext.getProcessInstanceId(),
- taskExecutionContext.getTaskInstanceId());
- taskExecutionContext.setExecutePath(execLocalPath);
- FileUtils.createWorkDirIfAbsent(execLocalPath);
+ // String execLocalPath = FileUtils.getProcessExecDir(
+ // taskExecutionContext.getProjectCode(),
+ // taskExecutionContext.getProcessDefineCode(),
+ // taskExecutionContext.getProcessDefineVersion(),
+ // taskExecutionContext.getProcessInstanceId(),
+ // taskExecutionContext.getTaskInstanbu iceId());
+ // taskExecutionContext.setExecutePath(execLocalPath);
+
FileUtils.createWorkDirIfAbsent(taskExecutionContext.getExecutePath());
Review Comment:
> Yes, if it's not yarn job, aop code will not execute. However, all types
of tasks will generate execution path (as well as appInfoPath) in master, so i
don't get what you mean "impossible to get the execution path", would you like
to explain it in detail?
@Radeity sorry ,I found where you are setting the value. I have no doubts
about this piece of code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
