EricGao888 commented on code in PR #12244:
URL: https://github.com/apache/dolphinscheduler/pull/12244#discussion_r985673751
##########
tools/dependencies/known-dependencies.txt:
##########
@@ -116,7 +116,7 @@ jakarta.websocket-api-1.1.2.jar
jakarta.xml.bind-api-2.3.3.jar
jamon-runtime-2.3.1.jar
janino-3.0.16.jar
-javassist-3.27.0-GA.jar
+javassist-3.26.0-GA.jar
Review Comment:
A bit wired that I didn't touch anything related to this dependency, but
somehow CI detected we have both `javassist-3.27.0-GA.jar`
and `javassist-3.26.0-GA.jar` and failed. I checked the dependency tree and
found `org.reflections` depends on `javassist-3.26.0-GA.jar` but
`com.cronutils` depends on `javassist-3.27.0-GA.jar`.
At first, I made them both depend on `javassist-3.27.0-GA.jar` but
`RpcTest.java` failed with message like :
```
java.lang.RuntimeException: Timeout exception. Request id: 1. Request class
name: IUserService. Request method: hi
at
org.apache.dolphinscheduler.rpc.future.RpcFuture.get(RpcFuture.java:67)
at
org.apache.dolphinscheduler.rpc.remote.NettyClient.sendMsg(NettyClient.java:220)
at
org.apache.dolphinscheduler.rpc.client.ConsumerInterceptor.intercept(ConsumerInterceptor.java:72)
at
org.apache.dolphinscheduler.rpc.IUserService$ByteBuddy$YDGonXwq.hi(Unknown
Source)
at org.apache.dolphinscheduler.rpc.RpcTest.sendTest(RpcTest.java:49)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at
org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at
com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
at
com.intellij.rt.junit.IdeaTestRunner$Repeater$1.execute(IdeaTestRunner.java:38)
at
com.intellij.rt.execution.junit.TestsRepeater.repeat(TestsRepeater.java:11)
at
com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:35)
at
com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:235)
at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:54)
```
After that, I made them depend on `javassist-3.26.0-GA.jar` and things
looked fine.
Just now I checked the changes in `https://github.com/ronmamo/reflections`
repo and found they skipped `javassist-3.27.0-GA.jar`, I assume that there
could be some incompatibilities between `reflections` and
`javassist-3.27.0-GA.jar`, see:
https://github.com/ronmamo/reflections/compare/0.9.12...0.10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
