EricGao888 commented on code in PR #12244:
URL: https://github.com/apache/dolphinscheduler/pull/12244#discussion_r990739777


##########
tools/dependencies/known-dependencies.txt:
##########
@@ -116,7 +116,7 @@ jakarta.websocket-api-1.1.2.jar
 jakarta.xml.bind-api-2.3.3.jar
 jamon-runtime-2.3.1.jar
 janino-3.0.16.jar
-javassist-3.27.0-GA.jar
+javassist-3.26.0-GA.jar

Review Comment:
   Still not working. Seems we have 3 methods to solve this:
   
   * Method 1: Downgrade javassist to `3.26.0-GA.jar`, this version works well 
as I have tested.
   
   * Method 2: Keep things the way it was, which means `org.reflections` 
depends on `javassist-3.26.0-GA.jar` and `com.cronutils` depends on 
`javassist-3.27.0-GA.jar` and we add both versions to 
`tools/dependencies/known-dependencies.txt`
   
   * Method 3: Upgrade `org.reflections` to version `0.10.2` and make both 
`org.reflections` and `com.cronutils` depend on `javassist-3.28.0-GA.jar`. For 
this method, we need to solve the NullPointerException for this line of code: 
https://github.com/apache/dolphinscheduler/blob/165b9a58de4a92c9206a0c8f8f1cec85a1f4c9e8/dolphinscheduler-remote/src/main/java/org/apache/dolphinscheduler/rpc/remote/NettyServerHandler.java#L84
   
   @kezhenxu94 @ruanwenjun WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to