[GitHub] [dolphinscheduler] rickchengx commented on pull request #12348: [Improvement-12333][Test] Migrate all UT cases from jUnit 4 to jUnit 5 in microbench and e2e module

[GitBox]

rickchengx commented on PR #12348:
URL: 
https://github.com/apache/dolphinscheduler/pull/12348#issuecomment-1277100756

   Hi, @kezhenxu94 , could you please help me with this e2e problem?
   
   This PR wants to remove the junit4 api in the `e2e` module. But in 
`dolphinscheduler-e2e/dolphinscheduler-e2e-core/src/main/java/org/apache/dolphinscheduler/e2e/core/DolphinSchedulerExtension.java`,
 we cannot just remove or replace the `junit4` api  since 
`org.testcontainers.containers.Network` is used.
   
   <img width="1184" alt="截屏2022-10-13 14 22 18" 
src="https://user-images.githubusercontent.com/38122586/195518748-034969ce-a167-415b-8c39-bf45ba75d67e.png";>
   
   It seems that `Testcontainers` is tightly coupled with the JUnit 4.x rule 
API, and here is the limitation of `Testcontainers` from the article below:
   <img width="785" alt="截屏2022-10-13 14 32 59" 
src="https://user-images.githubusercontent.com/38122586/195519798-318584f9-268e-4b79-8a6e-f046a8487ce5.png";>
   
   * https://www.testcontainers.org/test_framework_integration/junit_5/
   
   
   If we want to migrate all UT cases from jUnit4 to Junit5 here, do we need to 
refactor the tests in `e2e` module.
   Note: `Testcontainers` is also used in `dolphinscheduler-api-test` module.
   
   cc @EricGao888 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org