rickchengx commented on PR #12348: URL: https://github.com/apache/dolphinscheduler/pull/12348#issuecomment-1278515925
@kezhenxu94 Thanks a lot for the comment, I agree with you. So we need to avoid the junit 4 api in our codebase. <img width="1184" alt="截屏2022-10-13 14 22 18" src="https://user-images.githubusercontent.com/38122586/195518748-034969ce-a167-415b-8c39-bf45ba75d67e.png";> As for the CI e2e failure, this is because I use`network = Network.newNetWork()` instead of `network = new NetWork()` and override the methods of `getId()`, `close()` and `apply()`. The reason I made this change was to avoid the import of `org.junit.runner.Description` and `org.junit.runners.model.Statement`. But `network = Network.newNetWork()` now cannot return the `networkId` and cause the CI failure. Now I have tried to use `network = Network.builder().id(networkId).build();`. I am not sure whether this could pass the CI. Maybe we could wait for the CI results before deciding what to do next. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
![https://user-images.githubusercontent.com/38122586/195518748-034969ce-a167-415b-8c39-bf45ba75d67e.png"](https://user-images.githubusercontent.com/38122586/195518748-034969ce-a167-415b-8c39-bf45ba75d67e.png"){kind=link}