Tianqi-Dotes commented on code in PR #12276:
URL:
https://github.com/apache/dolphinscheduler/pull/12276#discussion_r1000196580
##########
dolphinscheduler-dao/src/main/resources/sql/dolphinscheduler_mysql.sql:
##########
@@ -1982,8 +1982,8 @@ CREATE TABLE `t_ds_cluster`(
DROP TABLE IF EXISTS `t_ds_fav_task`;
CREATE TABLE `t_ds_fav_task`
(
- `id` bigint NOT NULL AUTO_INCREMENT COMMENT 'favorite task id',
- `task_name` varchar(64) NOT NULL COMMENT 'favorite task name',
+ `id` bigint NOT NULL AUTO_INCREMENT COMMENT 'id',
+ `task_type` varchar(64) NOT NULL COMMENT 'favorite task type name',
Review Comment:
> So it is mean this featrue should work in 3.1.0 but currently not work, am
I right?
Dear Jiajie, this is an upgrade to make the column name more appropriate. It
works without this pr changes.
##########
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/FavTask.java:
##########
@@ -34,6 +35,8 @@ public class FavTask {
@TableId(value = "id", type = IdType.AUTO)
private Long id;
+ //task type name
+ @TableField("task_type")
private String taskName;
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
