Tianqi-Dotes commented on code in PR #12276: URL: https://github.com/apache/dolphinscheduler/pull/12276#discussion_r1000571228
########## dolphinscheduler-dao/src/main/resources/sql/dolphinscheduler_mysql.sql: ########## @@ -1982,8 +1982,8 @@ CREATE TABLE `t_ds_cluster`( DROP TABLE IF EXISTS `t_ds_fav_task`; CREATE TABLE `t_ds_fav_task` ( - `id` bigint NOT NULL AUTO_INCREMENT COMMENT 'favorite task id', - `task_name` varchar(64) NOT NULL COMMENT 'favorite task name', + `id` bigint NOT NULL AUTO_INCREMENT COMMENT 'id', + `task_type` varchar(64) NOT NULL COMMENT 'favorite task type name', Review Comment: > does this feature already release? If released we should also add this incompatible change into https://dolphinscheduler.apache.org/en-us/docs/dev/user_doc/guide/upgrade/incompatible.html have submitted dml changes to mysql and postgre -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
