rickchengx commented on PR #12118: URL: https://github.com/apache/dolphinscheduler/pull/12118#issuecomment-1291804729
> > @caishunfeng Thanks a lot for the comment. > > So in the same directory: > > > > * If the user start `master-server` twice without changing the port, it will cause the error `master does not exist`. > > * If the user start `master-server` twice and change the port, it can work but the log is shared. And also the `pid` file will be overwritten so the first started `master-server` can not be killed through the `pid` file. > > > > So I think we should not allow users to start `master-server` (or other server) twice or more **in the same directory**, because this is likely to be a user's misoperation. > > If users need to start 2 `master-server` on the same machine, they should start in another directory with different ports. > > WDYT > > And this PR avoids secondary startup in the same directory by querying the server status through `pid` file before startup. If the server is already started, the script will cancel this launch. > > Looks good to me, cc @SbloodyS @DarkAssassinator Hi, @SbloodyS @DarkAssassinator , could you please help review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
