rickchengx commented on PR #12118:
URL: 
https://github.com/apache/dolphinscheduler/pull/12118#issuecomment-1297926431

   > 1.The pid will be considered modified or suspended, making it impossible 
to kill the thread. This happens often. 2.The pid in the pid file is 
inconsistent with the actual process number @rickchengx
   
   Hi, @hstdream , thanks for your comment.
   
   I got your concern. Actually, the `pid-file` method is commonly used on 
linux. 
   
   For example, Apache Spark `spark-daemon.sh` also use `pid-file` to check the 
status of process and kill the process as below:
   
   
https://github.com/apache/spark/blob/a01b86f9d4651562f960745fc621d710ae9295cc/sbin/spark-daemon.sh#L161-L173
   
   <img width="1279" alt="image" 
src="https://user-images.githubusercontent.com/38122586/199143574-e836abf9-b4ec-4f44-ac4d-e8ee7bb717a5.png";>
   
   And I think the location of `pid-file` is in $DOLPHINSCHEDULER_HOME, which 
is a directory that only admin can attach. It cannot be easily modified.
   
   WDYT
   
   cc @caishunfeng @SbloodyS 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to