Radeity commented on code in PR #12552:
URL:
https://github.com/apache/dolphinscheduler/pull/12552#discussion_r1005758921
##########
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/runner/WorkerTaskExecuteRunnable.java:
##########
@@ -216,15 +217,17 @@ protected void beforeExecute() {
TaskExecutionCheckerUtils.downloadResourcesIfNeeded(storageOperate,
taskExecutionContext, logger);
logger.info("Resources:{} check success",
taskExecutionContext.getResources());
+ TaskFilesTransferUtils.downloadUpstreamFiles(taskExecutionContext,
storageOperate);
Review Comment:
I think it's not elegant enough to simply download zip file before executing
and upload file after executing, cuz intermediate data maybe large-scale. Slice
and buffer write will be better and also bring some benefits for prefetching
for downstream task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
