caishunfeng commented on code in PR #12570:
URL:
https://github.com/apache/dolphinscheduler/pull/12570#discussion_r1007706860
##########
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java:
##########
@@ -1512,6 +1515,10 @@ private void submitStandByTask() {
logger.info("remove task {},id:{} , because depend result
: {}", task.getName(), task.getId(), dependResult);
}
}
+ for (TaskInstance task : skipSubmitInstances) {
+ readyToSubmitTaskQueue.put(task);
Review Comment:
Why need to add back these skip task instances ?
##########
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java:
##########
@@ -1472,6 +1473,8 @@ private void submitStandByTask() {
long failedTimeInterval = DateUtils.differSec(new
Date(), retryTask.getEndTime());
if ((long) retryTask.getRetryInterval() *
SEC_2_MINUTES_TIME_UNIT > failedTimeInterval) {
logger.info("task name: {} retry waiting has not
exceeded the interval time, and skip submission this time, task id:{}",
task.getName(), task.getId());
+ readyToSubmitTaskQueue.remove(task);
Review Comment:
```suggestion
removeTaskFromStandbyList(task);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
