[GitHub] [dolphinscheduler] JinyLeeChina commented on a diff in pull request #12570: [Bugfix-12568] [Master] The retry task was submitted in advance will block other task

Thu, 27 Oct 2022 23:56:52 -0700 


JinyLeeChina commented on code in PR #12570:
URL: 
https://github.com/apache/dolphinscheduler/pull/12570#discussion_r1007713223


##########
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java:
##########
@@ -1472,6 +1473,8 @@ private void submitStandByTask() {
                         long failedTimeInterval = DateUtils.differSec(new 
Date(), retryTask.getEndTime());
                         if ((long) retryTask.getRetryInterval() * 
SEC_2_MINUTES_TIME_UNIT > failedTimeInterval) {
                             logger.info("task name: {} retry waiting has not 
exceeded the interval time, and skip submission this time, task id:{}", 
task.getName(), task.getId());
+                            readyToSubmitTaskQueue.remove(task);

Review Comment:
   Noļ¼Œhere not need logs



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to