rickchengx commented on code in PR #11589:
URL:
https://github.com/apache/dolphinscheduler/pull/11589#discussion_r1028923391
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/pom.xml:
##########
@@ -48,5 +48,10 @@
<artifactId>dolphinscheduler-datasource-api</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.dolphinscheduler</groupId>
+ <artifactId>dolphinscheduler-service</artifactId>
+ <version>${project.version}</version>
+ </dependency>
Review Comment:
> I am not sure wether we should dependent `dolphinscheduler-service` in
task plugin or not
> Do you have time to take a look @caishunfeng @ruanwenjun
Hi @zhongjiajie Thanks a lot for your review and comment.
I add this dependent since `sqoop` task plugin needs to add its own mask
pattern to `SensitiveDataConverter`.
Maybe we should discuss whether it is appropriate to do so.
cc @caishunfeng @ruanwenjun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
