rickchengx commented on code in PR #11589:
URL:
https://github.com/apache/dolphinscheduler/pull/11589#discussion_r1028962143
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/pom.xml:
##########
@@ -48,5 +48,10 @@
<artifactId>dolphinscheduler-datasource-api</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.dolphinscheduler</groupId>
+ <artifactId>dolphinscheduler-service</artifactId>
+ <version>${project.version}</version>
+ </dependency>
Review Comment:
> Please remove this module in task-plugin.
Hi @caishunfeng , thanks for your comment.
This dependent is added in `dolphinscheudler-task-sqoop/pom.xml` since
`sqoop` task needs to add its mask pattern through
`SensitiveDataConverter.addMaskPattern()`, which is in
`sdolphinscheduler-service` module.
<img width="378" alt="截屏2022-11-22 15 32 05"
src="https://user-images.githubusercontent.com/38122586/203252444-09914e7e-ffe1-4249-a3ed-4f55ab55547b.png";>
Is your suggestion that we should move `SensitiveDataConverter` to another
module? (maybe `dolphinscheduler-task-api`?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
![https://user-images.githubusercontent.com/38122586/203252444-09914e7e-ffe1-4249-a3ed-4f55ab55547b.png"](https://user-images.githubusercontent.com/38122586/203252444-09914e7e-ffe1-4249-a3ed-4f55ab55547b.png"){kind=link}