[GitHub] [dolphinscheduler] DarkAssassinator commented on a diff in pull request #13013: [Fix-12981]add worker address validator and clear function.

Tue, 29 Nov 2022 05:42:30 -0800 


DarkAssassinator commented on code in PR #13013:
URL: 
https://github.com/apache/dolphinscheduler/pull/13013#discussion_r1034768207


##########
dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/utils/NetUtilsTest.java:
##########
@@ -115,4 +115,40 @@ public void testIsValidAddress() {
         Assertions.assertFalse(NetUtils.isValidV4Address(address));
     }
 
+    @Test
+    public void 
giveIpAddress_thenCheckIsValidIPv4Address_thenCheck_expectNormal() {
+        Assertions.assertFalse(NetUtils.isValidIPv4Address(""));
+
+        String ipAddress = "127.0.0.1";

Review Comment:
   > can you add a host case?
   > 
   > BTW, in k8s deploy, the server host like: 
![image](https://user-images.githubusercontent.com/11962619/204452728-84281d3c-340d-4a83-a201-90e95c251f76.png)
   
   sure, but the format of the `host` is too broad, i want to just add a fuzzy 
check. WDYT.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to