Radeity commented on code in PR #13092:
URL:
https://github.com/apache/dolphinscheduler/pull/13092#discussion_r1038982432
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/SchedulerServiceImpl.java:
##########
@@ -171,6 +171,9 @@ public Map<String, Object> insertSchedule(User loginUser,
scheduleObj.setProcessDefinitionName(processDefinition.getName());
ScheduleParam scheduleParam = JSONUtils.parseObject(schedule,
ScheduleParam.class);
+ if (now.after(scheduleParam.getStartTime())) {
+ scheduleParam.setStartTime(now);
+ }
Review Comment:
Hi, @DarkAssassinator, i have thought again, maybe there's not a strong need
to move this simple condition judgement into a separate method, like other
`startTime` related checks, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
