Radeity commented on code in PR #13092:
URL:
https://github.com/apache/dolphinscheduler/pull/13092#discussion_r1039408061
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/SchedulerServiceImpl.java:
##########
@@ -171,6 +171,9 @@ public Map<String, Object> insertSchedule(User loginUser,
scheduleObj.setProcessDefinitionName(processDefinition.getName());
ScheduleParam scheduleParam = JSONUtils.parseObject(schedule,
ScheduleParam.class);
+ if (now.after(scheduleParam.getStartTime())) {
+ scheduleParam.setStartTime(now);
Review Comment:
> It's better don't modify the user's input, this may be thought as a bug.
Okay, i'll make some changes that return warning message if setting start
time earlier than current time, also change the default start time in front-end
to 0:00 of the next day? WDYT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
