xxjingcd commented on PR #13478:
URL: 
https://github.com/apache/dolphinscheduler/pull/13478#issuecomment-1413058071

   > In addition, i think there's nothing wrong with current way which move 
configuration files into classpath, i just wonder do we really have to make 
this change?
   
   It is not  convenient enough. You have to copy hdfs-site.xml and 
core-site.xml to the classpath manually; And it will bring maintenance costs,  
users  have to remember that  copy again when configuration files change ;
   
   >I think we should better avoid using system env, maybe we can add 
hadoop.conf.dir in our property file.
   
   It is a choice for users , you can still move configuration files into 
classpath. This only takes effect if you specify an environment variable;
   **And the environment variables are usually already configured in the 
operating system**;  That mean users can load correct configuration without 
doing anything. 
   It is a general approach;
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to