Radeity commented on PR #13478: URL: https://github.com/apache/dolphinscheduler/pull/13478#issuecomment-1415182867
> I know very little about k8s. Maybe you can use env in dockerfile or config dolphinscheduler_env.sh similar to how you configure properties files. @xxjingcd Sorry for my mistake, we have already created environment variables with `configMap` in k8s deploy mode, including configuration `HADOOP_CONF_DIR`. > Is this convenient for users to configure HDFS? In this PR, i think you don't have to change that part of codes, it's up to users whether override hdfs configuration or not. > Whether it is convenient enough to configure environment variables `HADOOP_CONF_DIR`. For me, there's no problem, please update docs in resource center configuration page : ) Also, you don't have to add environment configuration in `dolphinscheduler_env.sh` (refer to https://github.com/apache/dolphinscheduler/pull/13028). Basically LGTM, cc @zhongjiajie @EricGao888 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
