Radeity commented on code in PR #13051:
URL:
https://github.com/apache/dolphinscheduler/pull/13051#discussion_r1101461129
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java:
##########
@@ -741,7 +742,11 @@ public WorkflowSubmitStatue call() {
return WorkflowSubmitStatue.SUCCESS;
} catch (Exception e) {
log.error("Start workflow error", e);
- return WorkflowSubmitStatue.FAILED;
+ if (e instanceof SQLException) {
+ return WorkflowSubmitStatue.FAILED;
+ } else {
+ return WorkflowSubmitStatue.ERROR;
+ }
Review Comment:
I suggest not to distinguish these two types of error, rather, DB failure
will keep writing logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
