fuchanghai commented on PR #13051:
URL: 
https://github.com/apache/dolphinscheduler/pull/13051#issuecomment-1424211399

   if exception is not type of sqlexception。master will print log until have 
not enough space
   
   
   
   ---Original---
   From: "Aaron ***@***.***>
   Date: Thu, Feb 9, 2023 21:27 PM
   To: ***@***.***>;
   Cc: ***@***.***>;"State ***@***.***>;
   Subject: Re: [apache/dolphinscheduler] [improve-#13045] add max submit 
numberof workflow (PR #13051)
   
   
   
   
    
   @Radeity commented on this pull request.
    
    
   In 
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java:
    > +            if (e instanceof SQLException) { +                return 
WorkflowSubmitStatue.FAILED; +            } else { +                return 
WorkflowSubmitStatue.ERROR; +            }  
   I suggest not to distinguish these two types of error, rather, DB failure 
will keep writing logs.
    
   —
   Reply to this email directly, view it on GitHub, or unsubscribe.
   You are receiving this because you modified the open/close state.Message ID: 
***@***.***>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to